Skip to content

Use AWS v2 SDK for S3 in product tests #26246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2025
Merged

Use AWS v2 SDK for S3 in product tests #26246

merged 1 commit into from
Jul 23, 2025

Conversation

electrum
Copy link
Member

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jul 20, 2025
@dekimir dekimir mentioned this pull request Jul 21, 2025
Open
@wendigo
Copy link
Contributor

wendigo commented Jul 22, 2025

Test failure is related:

tests               | 2025-07-23 01:00:20 INFO: ManageTestResources.onFinish: running checks
tests               | FATAL: io.trino.testng.services.ManageTestResources: 
tests               | 	Test instance field has value that looks like a resource
tests               | 	    Test class: class io.trino.tests.product.deltalake.TestDeltaLakeActiveFilesCache
tests               | 	    Instance: io.trino.tests.product.deltalake.TestDeltaLakeActiveFilesCache@4f2d995e
tests               | 	    Field: private software.amazon.awssdk.services.s3.S3Client io.trino.tests.product.deltalake.TestDeltaLakeActiveFilesCache.s3
tests               | 	    Value: software.amazon.awssdk.services.s3.DefaultS3Client@2919aff3
tests               | 	    Test execution stage: AFTER_CLASS
tests               | 	    Matching rule: isAutoCloseable
tests               | 
tests               | 	Resources must not be allocated in a field initializer or a test constructor,
tests               | 	and must be freed when test class is completed.
tests               | 	Depending which rule has been violated, if the reported class holds on
tests               | 	to resources only conditionally, you can add @ResourcePresence to declare that.
tests               | 
tests               | JVM will be terminated
tests               | (exited)
tests               | (exited)

@wendigo
Copy link
Contributor

wendigo commented Jul 23, 2025

I've fixed remaining issues in the delta-lake tests (unclosed s3 instances)

@electrum
Copy link
Member Author

Thanks. Do you know why we didn't have this problem before?

@electrum electrum merged commit 8209002 into trinodb:master Jul 23, 2025
41 checks passed
@github-actions github-actions bot added this to the 477 milestone Jul 23, 2025
@wendigo
Copy link
Contributor

wendigo commented Jul 23, 2025

@electrum I guess because previous client wasn't a Closeable?

@ebyhr ebyhr mentioned this pull request Aug 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

Assignees
No one assigned
Labels
cla-signed
Milestone
477
Development

Successfully merging this pull request may close these issues.
2 participants
@electrum @wendigo